babel-plugin-react-docgen icon indicating copy to clipboard operation
babel-plugin-react-docgen copied to clipboard

chore: use [email protected]

Open joshwooding opened this issue 4 years ago • 5 comments

[email protected] is out and allows resolving of imported types/proptypes and has no breaking changes (https://github.com/reactjs/react-docgen/releases/tag/v6.0.0-alpha.0). We want to explore this in https://github.com/eirslett/storybook-builder-vite/pull/167 any chance of releasing this dependency bump as an alpha to test the waters?

joshwooding avatar Dec 10 '21 21:12 joshwooding

I think there may be additional work to get this to work, by default this new behavior is not enabled to be backwards compatible

we need to pass makeFsImporter to the parse method from what I understand

From the original PR

Made the "importer" configurable. It is passed as an argument to the parse method, but if using the defaultParse from main.js, it is an additional option that can be specified. This is to make everything backwards compatible.

mscott2757 avatar Jan 11 '22 21:01 mscott2757

@mscott2757 I've got a fork of this working here, would you be open to a PR back here with a similar implementation? Were you thinking that there would also need to be an option for the plugin to enable/disable the importer? or provide a different importer altogether?

silawrenc avatar Feb 09 '22 15:02 silawrenc

Hi folks, just bumping this PR because we're maintaining a fork of the changes it makes over here. Are there any other changes to be considered at all other than the ones discussed so far?

rp4rk avatar Apr 11 '22 15:04 rp4rk

I noticed that react-docgen is being actively developed again. The -alpha.0 was released over a year ago, but last month there were newer releases (with breaking changes).

Sounds like a good time to consider supporting 6.0 in storybook core.

mayank99 avatar May 18 '22 17:05 mayank99

And now 6.0 is out!

stianjensen avatar Jun 16 '23 21:06 stianjensen