addon-coverage icon indicating copy to clipboard operation
addon-coverage copied to clipboard
verified publisher icon storybookjs

Update dependencies and package structure to support ESM

Open yannbf opened this issue 1 year ago • 5 comments

Closes #49 Relates to https://github.com/storybookjs/storybook/issues/26291

This PR does the following:

  • Replace TSC+Babel with TSUP for building the addon
  • Refactor the library accordingly
  • Stop using require in viteFinal so vite doesn't use CJS
  • Upgrade vite-plugin-istanbul from 3.x to 6.x
  • Adds some tests in the stories to check that coverage exists
📦 Published PR as canary version: 2.0.0--canary.51.dcd0bca.0

:sparkles: Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

yannbf avatar Dec 24 '24 14:12 yannbf

Is this still waiting for something?

Smeky avatar Feb 11 '25 17:02 Smeky

I am too looking forward to this PR. Great work!

thefrana avatar Feb 12 '25 12:02 thefrana

@yannbf I guess we want to merge this?

kasperpeulen avatar Feb 12 '25 12:02 kasperpeulen

Any chance we can get this merged? 🙏

Romainpetit avatar Mar 06 '25 16:03 Romainpetit

@yannbf Can you provide some information of what's necessary to get this merged?

valentinpalkovic avatar Mar 24 '25 14:03 valentinpalkovic

@yannbf Can we get this merged this week?

valentinpalkovic avatar Jun 11 '25 19:06 valentinpalkovic