storybook-nuxt icon indicating copy to clipboard operation
storybook-nuxt copied to clipboard

Versions since 0.2.1

Open daniluk4000 opened this issue 1 year ago • 13 comments

Hey there. Can't speak for everyone, but for our project all versions since 0.2.1 didn't work.

0.2.5 just released without any commit or changelog in this repo, and it also doesn't build with brand new "RollupError: Expression expected" error.

Is this normal or are we doing something wrong?

daniluk4000 avatar Mar 18 '24 08:03 daniluk4000

For now we'll keep skipping versions

image

daniluk4000 avatar Mar 18 '24 08:03 daniluk4000

For now we'll keep skipping versions

image

I apologize for the inconvenience I had to force some changes to fix there is no proper changelog for now. I will cleanup later once I got to stable version

chakAs3 avatar Mar 18 '24 18:03 chakAs3

fwiw, I managed to get my storybook running using the from-0.2.1 branch, after I updated all dependencies. additionally, I also had to insert this line (else storybook didnt understand my vue files at all):

--- a/packages/storybook-nuxt/src/preset.ts
+++ b/packages/storybook-nuxt/src/preset.ts
@@ -101,6 +101,7 @@
           else {
             // Handle the case where the plugin with name 'vite:vue' was not found
             console.error('Plugin \'vite:vue\' not found in the array.')
+            plugins.push(vuePlugin())
           }
           baseConfig.plugins = plugins
           extendedConfig = mergeConfig(config, baseConfig)

do you want me to PR that?

MiniDigger avatar Mar 21 '24 12:03 MiniDigger

fwiw, I managed to get my storybook running using the from-0.2.1 branch, after I updated all dependencies. additionally, I also had to insert this line (else storybook didnt understand my vue files at all):

--- a/packages/storybook-nuxt/src/preset.ts
+++ b/packages/storybook-nuxt/src/preset.ts
@@ -101,6 +101,7 @@
           else {
             // Handle the case where the plugin with name 'vite:vue' was not found
             console.error('Plugin \'vite:vue\' not found in the array.')
+            plugins.push(vuePlugin())
           }
           baseConfig.plugins = plugins
           extendedConfig = mergeConfig(config, baseConfig)

do you want me to PR that?

i think this issue was already addressed in other commit, the history is not clean i'm sorry for that. you can open a PR i will review it that release a new tag.

i already released v0.2.5 you can try it.

chakAs3 avatar Mar 21 '24 13:03 chakAs3

I tried v0.2.5 already, for the record, I am talking about this issue:

[15:43:47]  ERROR  Internal server error: Failed to parse source for import analysis because the content contains invalid JS syntax. Install @vitejs/plugin-vue to handle .vue files.
  Plugin: vite:import-analysis
  File: xxxxxx/node_modules/nuxt/dist/app/components/nuxt-root.vue:15:27

manually adding that line in the node_modules folder is enough to fix it for me. its not an issue with my project since I get it in the playground too, maybe something broke again with newer nuxt 🤷 ill clean up my working tree and PR when I am home in a bit so you can take a look.

MiniDigger avatar Mar 21 '24 14:03 MiniDigger

https://github.com/storybook-vue/storybook-nuxt/pull/95

MiniDigger avatar Mar 21 '24 16:03 MiniDigger

I tried v0.2.5 already, for the record, I am talking about this issue:

[15:43:47]  ERROR  Internal server error: Failed to parse source for import analysis because the content contains invalid JS syntax. Install @vitejs/plugin-vue to handle .vue files.
  Plugin: vite:import-analysis
  File: xxxxxx/node_modules/nuxt/dist/app/components/nuxt-root.vue:15:27

manually adding that line in the node_modules folder is enough to fix it for me. its not an issue with my project since I get it in the playground too, maybe something broke again with newer nuxt 🤷 ill clean up my working tree and PR when I am home in a bit so you can take a look.

image still got the same error this is after ur pr is merged. 0.2.5

alniv94 avatar Mar 25 '24 09:03 alniv94

0.2.5 doesnt include the PR yet

MiniDigger avatar Mar 25 '24 09:03 MiniDigger

Okay thanks, will wait for the release

alniv94 avatar Mar 25 '24 09:03 alniv94

0.2.5 doesnt include the PR yet

I did pull ur pr yet the issue still present. Can u confirm? Thanks

alniv94 avatar Mar 25 '24 11:03 alniv94

I am running that branch with no issues at my end (other than the fact that it doesnt like lazy components)

MiniDigger avatar Mar 25 '24 13:03 MiniDigger

New error for me in 0.2.6...

image

daniluk4000 avatar Mar 29 '24 13:03 daniluk4000

0.2.1 is the only version that works right now

Al-Rozhkov avatar Apr 02 '24 13:04 Al-Rozhkov

New error for me in 0.2.6...

image

Could you please open a new issue (at https://github.com/nuxt-modules/storybook/) for this with more details. Thanks!

Closing as the original issue has been resolved.

tobiasdiez avatar Jun 01 '24 05:06 tobiasdiez