storybook-deployer
storybook-deployer copied to clipboard
Invalid deployment URL for ssh remotes
When using an ssh remote URL it seems to produce invalid GitHub pages link:
=> Deploying storybook
executing: git push --force --quiet [email protected]:feimosi/my-repo.git master:gh-pages
=> Storybook deployed to: https://git.github.io/my-repo/
Should be of course: https://feimosi.github.io/my-repo/
I've tried to trace the issue down the dependency tree:
https://github.com/IonicaBizau/git-url-parse
↓
https://github.com/IonicaBizau/git-up
↓
https://github.com/pillarjs/parseurl
and seems like the underlying node-url
package doesn't support this type of an URL. You'd probably have to handle this case here or report it to git-up
package.
@feimosi can you report this to the git-up repo?
@feimosi did you end up posting this on the git-up repo? Did you solve the issue or do you have a link to the issue?
So apparently this has been fixed in https://github.com/IonicaBizau/git-up/issues/17
However this package stil depends on outdated git-url-parse
and therefore git-up
versions.
Hi. Any news on this? It still doesn't work.