react-cdk icon indicating copy to clipboard operation
react-cdk copied to clipboard

Storybook v3

Open usulpro opened this issue 8 years ago • 6 comments

We can switch to Storybook v3!

Is there anyone interested in this?

usulpro avatar Jul 15 '17 19:07 usulpro

Todo:

  • [ ] Switch to @storybook/react

  • [ ] Use storybook-deployer

  • [ ] Switch to Jest for testing

  • [ ] Use @storybook/react/demo for demo components

usulpro avatar Jul 15 '17 20:07 usulpro

Yes - I was just about to dust off my favorite react-cdk, for a new component... but without storybook3 it makes me wonder if I should...

It is supposed to always be "updated" but the base template is already month+ behind?

Please do update so others will continue to trust this great template/dev-kit... I love it... want to keep having it around...


I just created a new cdk component, then immediately ran getstorybook to update it...

ss

zeroasterisk avatar Jul 18 '17 02:07 zeroasterisk

Any update on this?

juliomenendez avatar Aug 28 '17 15:08 juliomenendez

@UsulPro is this still something we'd like to support going forward?

I think we should either support this full on and have an active maintainer for this or deprecate this to focus other Storybook improvements.

danielduan avatar Aug 28 '17 16:08 danielduan

@danielduan I'd like to pull it up to Storybook 3 level. And then integrate it somehow with getstorybook in order to fill the lack when it's running inside an empty folder. Actually, getstorybook and react-cdk use very similar templates, so it could help to maintain it. And we could share own storybook dev tools settings in order to keep it in a good fit. (We have related work in Storybook cli by @Hypnosphi -- https://github.com/storybooks/storybook/pull/1647)

I guess this project could be useful in some narrow areas:

  • creating component libraries
  • example && test of manually configured react/storybook app

Maybe somebody who uses it can add other use cases.

On the other hand, I agree with you, we can't do anything without good maintainers team and obviously, I do not have enough time to do it only by myself. We could call the community do somebody want to help or deprecate it otherwise.

usulpro avatar Aug 28 '17 19:08 usulpro

I think we should deprecate this. I don't think users lose much if they move to create-react-app + sStorybook/react

It's been months since Storybook 3 came out but there hasn't been much activity in the issues here and no PRs for the last half year.

danielduan avatar Aug 28 '17 22:08 danielduan