hannah

Results 180 comments of hannah

@mtb-za you can always start w/ a really rough PR and ask us to mark it as a draft if you wanna publicly hash it out.

This probably interacts w/ #6738 in some way given the idea behind that was to be able to write an rcparams to file. I think a first pass/easy/low cost improvement...

Go for it! We generally don't assign issues, but first person with an open PR gets priority. https://matplotlib.org/devdocs/devel/index.html

I think if the grid line color is considered part of the 'unchangable style API' then it should be documented, and I think the current way that style is documented...

> Could it be because of not passing any kwargs Yup, if no argument is passed then the setting is toggled. I think it may be better to be explicit...

Um @jklymak and @timhoffm, are either of your reservations strong enough to block merging #23730

> the grid color is reasonable and thus not important #23598 exists because it's debatable whether the grid color is reasonable. I understand it's a small thing and probably not...

thanks for the PR! I think this is a reasonable change (though I'd prefer the grid a touch darker) given that in light mode the grid is lighter than the...

> Even darker? Did you mean lighter? Something like 777777 maybe? Yeah, sorry meant brighter/closer to white, something in the .7-.9 range

> @story645 do you want me to update the commit to switch to 777777? Yes @jklymak if we can't change the existing style*, then I think in this case it's...