storrrrrrrrm
storrrrrrrrm
> I think this is the expected behavior of the ray_ground_filter. Why do you want to run it in a different frame? > > The way it uses the frame...
> @storrrrrrrrm > > > if designed to be worked with base_link only, maybe it is better to set base_frame to a const value in code rather than a ros...
@yukkysaito @miursh do you mean that "base_frame" is actually a non-modified parameter? scan_ground_filter works well when 'base_frame' set to 'velodyne_top'
> @storrrrrrrrm > > > do you mean that "base_frame" is actually a non-modified parameter? > > Right. I mean it. But let me check the codes to confirm. Do...
> @storrrrrrrrm could you please rebase this PR to main? latest main branch code merged and add read params from [ground_segmentation.param.yaml](https://github.com/autowarefoundation/autoware.universe/blob/1bbf9cdde9f2ee7e7d5c6d676902de5c54a0d040/launch/tier4_perception_launch/config/obstacle_segmentation/ground_segmentation/ground_segmentation.param.yaml)
> @storrrrrrrrm [The mentioned PR](https://github.com/autowarefoundation/autoware.universe/pull/1401) only adds the test and this issue still needs to be resolved right? no, i added a z_offset and solved this issue already in #1401,...
> @storrrrrrrrm could you rebase this PR to main branch and look into the review here? Thanks! [#1401 (review)](https://github.com/autowarefoundation/autoware.universe/pull/1401#pullrequestreview-1145044407) sorry for late reply. now latest code merged and more params...
> @storrrrrrrrm Is this PR ready to be merged? Is there any concerns left? it is ready, no concerns for now.
> @storrrrrrrrm I'm sorry but there is some CI errors https://github.com/autowarefoundation/autoware.universe/actions/runs/3656389069/jobs/6178779313 Could you resolve this? sorry,but I can't reproduce this issue in my local environment. ci complains that it can...
> So, it would be better to make a copy of tier4_perception_launch/config/obstacle_segmentation/ground_segmentation.param.yaml to ground_segmentation/config/ground_segmentation.param.yaml and refer to it. read params from ground_segmentation.param.yaml comes from [badai-nguyen](https://github.com/badai-nguyen) opinion > IMO, it is...