Mauren comments

Results 173 comments of


                                            Mauren

perf: Improve resmap performance with AppendAll and Transform functions

Hi there, @chlunde! 👋🏻 I noticed this PR is still in draft state. Would you like to have it be reviewed again?

support verification of the signature with multiple public keys

For the CLI, would it be fair to have flags specifying the policy (i.e., `--policy-type any-of/all-of`) and a threshold number (i.e., `--threshold 1`)?

fix: Allow patches with empty files with multiple newlines or comments

> Hi @stormqueen1990 @varshaprasad96, > > Could I get some help in getting this approved? > > Thank you! Hi there, @jchanam! I am taking a look at this and...

fix: Allow patches with empty files with multiple newlines or comments

/test all

fix: Allow patches with empty files with multiple newlines or comments

/test all

fix: Allow patches with empty files with multiple newlines or comments

> @stormqueen1990 Sorry for the late response. I think I was able to follow your guidance and fix the tests. Hi there, @jchanam! Thanks for updating this!

fix: Allow patches with empty files with multiple newlines or comments

/retest

fix: Allow patches with empty files with multiple newlines or comments

> @stormqueen1990 Could you please help me with the linter errors? > > ``` > Error: plugin/builtin/patchtransformer/PatchTransformer_test.go:1128:29: test helper function should start from t.Helper() (thelper) > `, someDeploymentResources, func(t *testing.T,...

fix: Allow patches with empty files with multiple newlines or comments

> @stormqueen1990 what is the following step now that the PR passed all the tests? Could this PR be merged? Hi there, @jchanam! The next step is the review and...

fix: Allow patches with empty files with multiple newlines or comments

> Hi! > > I'm still waiting for any maintainer to approve and merge this. Is there any way to ping anyone so they can check this? @koba1t or @varshaprasad96:...