stormpath-flask icon indicating copy to clipboard operation
stormpath-flask copied to clipboard

Add ID Site support

Open denibertovic opened this issue 10 years ago • 8 comments

denibertovic avatar Dec 03 '14 15:12 denibertovic

Hey Deni, would you mind pulling in the latest develop changes and fixing the conflicts? I think there were some issues because the other PR fixed some of the same stuff as this, so there was some conflicts there.

rdegges avatar Dec 10 '14 17:12 rdegges

@rdegges updated.

denibertovic avatar Dec 10 '14 21:12 denibertovic

ping @rdegges

denibertovic avatar Jan 23 '15 14:01 denibertovic

@avojnovicDk heyo! Comments to follow =)

rdegges avatar Apr 23 '15 16:04 rdegges

We're also going to need to get some docstrings added to all helper functions / methods that are included in this library. In the Flask stuff the code is all pretty standardized style wise.

Also: some style things need to change, primarily:

  • When specifying params like:
blah(
    val=1,
    val=2,
)

You'll need to add spaces around the operator, eg:

blah(
    val = 1,
    val = 2,
)

This is just to keep stuff consistent.

rdegges avatar Apr 23 '15 16:04 rdegges

We also are missing some tests for this feature which will need to be added in, but those can be created pretty quickly I think. Just to assert the settings are being added properly, etc.

rdegges avatar Apr 23 '15 16:04 rdegges

@rdegges ^^ Also, for the spaces around the = sign, there shouldn't be any when specifying params. See PEP8 for that: https://www.python.org/dev/peps/pep-0008/#other-recommendations

avojnovicDk avatar Apr 24 '15 17:04 avojnovicDk

Quick ping -- wanna add some tests for this? Would be happy to merge it in =)

rdegges avatar May 13 '15 00:05 rdegges