Samuel Verschelde

Results 347 comments of Samuel Verschelde

(Ideally, @Danp2 should review the changes made after his comments and Approve the PR)

I don't know why it closed the PR after my force-push to remove the merge commit.

Looks like there's something I don't understand in how github works with forks and pushes to PRs. I'll create a new PR with these changes.

Thanks for the report. Forwarding to the team.

The root cause is in `/etc/profile.d/xcp-ng-prompt.sh`.

Added Gaëtan as reviewer because he has a strong point.

> All suggestion are reviewed ! But it's still marked WIP. Main reason for which I haven't reviewed yet.

> @stormi it marked it as WiP because I didn't want someone merging it without having some proofreading and opinion from other people. Just ask people for review, we'll not...

It's a good idea to add a word about TLS certificates, but the method described is not appropriate. This must be done using XAPI methods. Ideally, we'd just link towards...