protodep icon indicating copy to clipboard operation
protodep copied to clipboard

proto-dep does not support repos with any group depth

Open seanamos opened this issue 4 years ago • 6 comments

While github.com only has repos (for now) with the following structure: github.com/{owner}/{repo}.git, other hosting services (gitlab.com) can have repos with the following structure: gitlab.com/a/b/c/d/e/f.git (subgroups).

When trying to use a repo like: gitlab.com/a/b/c/d as a target, proto-dep will try connect to ssh://gitlab.com/a/b.git.

The quick fix is to change pkg/config/schema.go/Repository() to return the target as specified. Testing locally, this just works. However, this is technically a breaking change.

seanamos avatar Feb 13 '22 19:02 seanamos

@seanamos Would you please send a pull request to this repository? I want to confirm and consider it.

stormcat24 avatar Feb 26 '22 12:02 stormcat24

Sure, I can push what I have my side.

seanamos avatar Mar 02 '22 07:03 seanamos

Is this still a problem? Currently trying to use subgroup paths (gitlab) and it seems to have the same issue.

belenkoArrival avatar Mar 14 '22 09:03 belenkoArrival

@belenkoArrival Yes the problem still exists. I apologize, I haven't had time to push up a PR with the fix (which is quite simple), my youngest son was born just a few days ago so I simply haven't had time.

seanamos avatar Mar 14 '22 12:03 seanamos

look forward to solving this problem at an early date...

seosite avatar Aug 06 '22 01:08 seosite

look forward to solving this problem at an early date...

hr3685930 avatar Aug 06 '22 06:08 hr3685930