gateway-st icon indicating copy to clipboard operation
gateway-st copied to clipboard

rclone test suite failures

Open halkyon opened this issue 3 years ago • 0 comments

When running the rclone test suite, there are currently a couple of failures in the fs/operations test suite, relating to storage tier, and modification times. Some of these were fixed in https://github.com/storj/gateway-st/commit/5be39edd49e42301a435718ff1dc03a4693d0320, but there are still some failures remaining.

This can be replicated by starting Gateway-ST locally with a working storj-sim, checking out rclone, building and running the test runner and running it:

cd /tmp
git clone https://github.com/rclone/rclone
cd rclone
git checkout v1.57.0

go build ./fstest/test_all
go build

./rclone config create TestS3 s3 \
  env_auth false \
  provider Minio \
  endpoint "http://127.0.0.1:7777" \
  access_key_id "$(storj-sim network env GATEWAY_0_ACCESS_KEY)" \
  secret_access_key "$(storj-sim network env GATEWAY_0_SECRET_KEY)" \
  upload_concurrency 16 \
  chunk_size 64M \
  upload_cutoff 64M

./test_all -backends s3 -remotes TestS3: -maxtries 1 -verbose

In order to work around the failures, the broken tests can be filtered out by only running the working suite:

./test_all -backends s3 -remotes TestS3: -tests "fs/sync" -maxtries 1 -verbose

Example failures from the "fs/operations" suite that are failing:

=== RUN   TestIntegration/FsMkdir/FsPutFiles/SetTier
    fstests.go:1662: 
        	Error Trace:	fstests.go:1662
        	Error:      	Expected nil, but got: &s3err.RequestFailure{RequestFailure:(*awserr.requestError)(0xc0000ca500), hostID:""}
        	Test:       	TestIntegration/FsMkdir/FsPutFiles/SetTier
    fstests.go:1664: 
        	Error Trace:	fstests.go:1664
        	Error:      	Not equal: 
        	            	expected: "STANDARD_IA"
        	            	actual  : "STANDARD"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-STANDARD_IA
        	            	+STANDARD
        	Test:       	TestIntegration/FsMkdir/FsPutFiles/SetTier
2021/12/10 15:39:08 DEBUG : no_checksum_big_file_from_pipe: Modification times differ by 87301h39m8.876543211s: 2011-12-25 12:59:59.123456789 +0000 UTC, 2021-12-10 02:39:08 +0000 UTC
2021/12/10 15:39:08 ERROR : no_checksum_big_file_from_pipe: corrupted on transfer
    operations_test.go:1467: 
        	Error Trace:	operations_test.go:1467
        	            				operations_test.go:1478
        	Error:      	Received unexpected error:
        	            	corrupted on transfer
        	Test:       	TestRcat
=== CONT  TestRcat/withChecksum=false,ignoreChecksum=false
    testing.go:1169: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
--- FAIL: TestRcat (0.41s)
    --- FAIL: TestRcat/withChecksum=false,ignoreChecksum=false (0.41s)

halkyon avatar Dec 10 '21 03:12 halkyon