edge icon indicating copy to clipboard operation
edge copied to clipboard

make limiting features consistent across Gateway-MT and Link Sharing Service

Open amwolff opened this issue 1 year ago • 4 comments

Goal

Gateway-MT has the per-macaroon head rate limiter and linksharing has a limit on the total number of requests as well as the ability to block certain paths. It would be valuable to make these options consistent.

Acceptance Criteria

  • Implement the limit on the total number of requests in GW-MT
  • Implement the per-macaroon head rate limiter in linksharing
  • Make the per-macaroon head rate limiter have the ability to rate limit project IDs as well
  • Make limiting options consistent under the same configuration key (e.g., --limits.[…])

Links

amwolff avatar Nov 18 '24 18:11 amwolff

Change pkg/linksharing: add limiter middleware mentions this issue.

storj-gerrit[bot] avatar Mar 04 '25 19:03 storj-gerrit[bot]

Change pkg/server: rename --concurrent-allowed mentions this issue.

storj-gerrit[bot] avatar Mar 04 '25 19:03 storj-gerrit[bot]

This looks like it's done. There's some follow-up work I raised an issue for here: https://github.com/storj/edge/issues/569

halkyon avatar May 05 '25 03:05 halkyon