drpc icon indicating copy to clipboard operation
drpc copied to clipboard

drpchttp: add helpers for ALPN support

Open hdonnay opened this issue 1 year ago • 2 comments
trafficstars

I was looking at using DRPC and would want to run it on the same server connection as an existing API. ALPN is the "native" way to do this, so I took a pass at implementing it. Sending a PR in case it's something that would be useful for upstream.

I couldn't find if there was a Gerrit instance this sort of thing should go to instead.

hdonnay avatar Jul 26 '24 17:07 hdonnay

Here's the rendered documentation for the added bits. (Looks like firefox mangled it a bit, sorry.) drpc_alpn_docs

hdonnay avatar Jul 26 '24 19:07 hdonnay

I finally checked my emails and saw this PR. I haven't taken a detailed look yet (I'll try to do that tomorrow), but I think this might live better in the drpcmigrate package (which is where we have code to do muxing based on some header prefix at the start of the data). The drpchttp package is more about serving drpc endpoints over http.

Also we do have gerrit at https://review.dev.storj.io/ but this works fine as well, whichever you prefer. I should add a link in the main README.

zeebo avatar Aug 11 '24 16:08 zeebo