common icon indicating copy to clipboard operation
common copied to clipboard

pb: Config service added: minimum selection version for upload added.

Open Qweder93 opened this issue 4 years ago • 2 comments

Change-Id: I2fdf1b1a5555e102c8f9a53af0d18b54786d23e7

What: added minimum selection version to nodestats

Why: all minimum selection versions from trusted satellites will be compared and newest version will be shown as version on which node still won't be disqualified, but would not receive new data, just storing.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • [ ] NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • [ ] Does the PR describe what changes are being made?
  • [ ] Does the PR describe why the changes are being made?
  • [ ] Does the code follow our style guide?
  • [ ] Does the code follow our testing guide?
  • [ ] Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • [ ] Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • [ ] Does any documentation need updating?
  • [ ] Do the database access patterns make sense?

Qweder93 avatar Jun 01 '21 11:06 Qweder93

@Qweder93 I adjusted the naming a bit.

egonelbre avatar Jun 03 '21 09:06 egonelbre

Is this still relevant?

Erikvv avatar Feb 03 '22 15:02 Erikvv

This has gotten significantly out of date. We can reopen if really needed.

egonelbre avatar Jul 18 '24 13:07 egonelbre