udisks icon indicating copy to clipboard operation
udisks copied to clipboard

Do not overwrite CPPFLAGS

Open mbiebl opened this issue 1 year ago • 2 comments

Use AM_CPPFLAGS instead of ovewriting CPPFLAGS. CPPFLAGS is a user variable reserved for local modifications. See https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html

mbiebl avatar Jul 04 '24 14:07 mbiebl

Can one of the admins verify this patch?

StorageGhoul avatar Jul 04 '24 14:07 StorageGhoul

In Debian we pass certain hardening build flags to all packages and I was wondering why that failed for udisks: https://salsa.debian.org/utopia-team/udisks2/-/jobs/5927192

Turns out that the udisks build system uses CPPFLAGS whereas it should use AM_CPPFLAGS

mbiebl avatar Jul 04 '24 14:07 mbiebl

Jenkins, ok to test.

vojtechtrefny avatar Jul 05 '24 05:07 vojtechtrefny