blivet icon indicating copy to clipboard operation
blivet copied to clipboard

Published 20 hours ago • verified publisher icon storaged-project

drop python<=3.7 support

Open kloczek opened this issue 10 months ago • 5 comments

Filter all python code over pyuprade --py38-plus and mark in setup.py that this module is only for python>=3.8.

kloczek avatar Mar 28 '24 16:03 kloczek

Can one of the admins verify this patch?

StorageGhoul avatar Mar 28 '24 16:03 StorageGhoul

Jenkins, ok to test.

vojtechtrefny avatar Apr 02 '24 10:04 vojtechtrefny

I don't see a reason for dropping the <= 3.7 support

blivet module is used by blivet-gui. At the moment it is not possible to build full GUI desktop without at least python 3.10 (mesa, some parts of gnome during build and rust rpm base tooling needs python>=3.10).

IIRC fc38 uses python 3.10 or 3.11 so with current CI definition it is not possible to test this module with python<=3.9.

In other words it is nothing more than just cutting some legacy tail 😋

kloczek avatar Apr 03 '24 17:04 kloczek

In other words it is nothing more than just cutting some legacy tail

Asi I said, I am not against doing this, but currently the tests are failing (static analysis is complaining about indentation) so if you want this merged, please fix the failures first.

vojtechtrefny avatar Apr 22 '24 11:04 vojtechtrefny

Is it any problem with merge this PR an add indentation fixes?

kloczek avatar Apr 22 '24 12:04 kloczek