stoplightio
fix: pin @stoplight/json dep to 3.20.0
Addresses #2566
Checklist
- The basics
- [x] I tested these changes manually in my local or dev environment
- Tests
- [ ] Added or updated
- [x] N/A
- Event Tracking
- [ ] I added event tracking and followed the event tracking guidelines
- [x] N/A
- Error Reporting
- [ ] I reported errors and followed the error reporting guidelines
- [x] N/A
cc @chohmann – any chance you could give this a quick stamp? the bad dep causes things to be Very Broken.
cc @mnaumanali94 can anyone take a look at this? it's breaking everything for us
@RobertCraigie The team should be able to look at this tomorrow. We're in a bit of a transition in terms of ownership - we apologize for the wait.
@mnaumanali94 anything we could do to persuade you to go ahead and release this? It's just a dependency pin to a previous-known-good version, and the breakage is quite bad (for us at least, and it seems, others too).
@rattrayalex This issue should be fixed now as a new version of stoplight/json should fix the error. Can y'all confirm please?
It looks like it's still failing but I haven't verified if this CI run is using the new stoplight/json version or not.
We've published a fork of prism-cli with the fix in this PR which is passing all our tests.
Also trying on the command line with the steps to reproduce It doesn't fail. Can you see if the CI is using the right version?
@mnaumanali94 see this CI run which includes a debug log showing the versions of all deps.
It's using @stoplight/[email protected] and failing.
It looks like the issue has been resolved by upgrading the dependency to @stoplight/json 3.20.7 . Overrides or pinned versions should not be neccesary any more, so this ticket can likely be closed.