json-schema-viewer icon indicating copy to clipboard operation
json-schema-viewer copied to clipboard

[Mosaic] deprecation notice from jotai

Open robbieaverill opened this issue 1 year ago • 2 comments

Context

The browser console is full of deprecation notices when using json-schema-viewer. I would love to help upgrade this dependency, however it seems like Mosaic is not an open source library.

Current Behavior

  • Load a page using json-schema-viewer
  • Open browser console
  • Notice many deprecation notices
  • Run a server-side build using a tool such as Vite, and notice that warnings are emitted during the build phase
console.js:273 [DEPRECATED]: use `useAtomValue` from `jotai` instead. 
    at Divider (webpack-internal:///../../common/temp/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@stoplight+mar_5xf4cu4e5qhaddtsd35lb2ujpe/node_modules/@stoplight/json-schema-viewer/index.mjs:787:20)
    at div
    at Box (webpack-internal:///../../common/temp/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@stoplight/mosaic/core.esm.js:759:3)
    at Flex (webpack-internal:///../../common/temp/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@stoplight/mosaic/core.esm.js:6125:3)
    at div

Expected Behavior

  • Deprecation notices are addressed and longer exist

Possible Workaround/Solution

Solution: upgrade Jotai and/or follow the deprecation notice recommendations.

  • Version used: json-schema-viewer 4.16.1, mosaic 1.53.2
  • Environment name and version (e.g. Chrome 39, node.js 5.4): Chrome 126, Node 20
  • Operating System and version (desktop or mobile): desktop
  • Link to your environment/workspace/project: N/A

robbieaverill avatar Jul 03 '24 22:07 robbieaverill

Fixed some of it as part of https://github.com/stoplightio/json-schema-viewer/pull/260

weyert avatar Aug 11 '24 10:08 weyert

Tried to address only this issue in #293. Hopeful that it might be easier to review/merge that way.

ElliotFriend avatar Feb 12 '25 15:02 ElliotFriend