http-spec icon indicating copy to clipboard operation
http-spec copied to clipboard

JSON Schema Generator using deprecated request library

Open strmer15 opened this issue 2 years ago • 0 comments

The @stoplight/json-schema-generator package is using the deprecated request library, which results in these yarn warnings when installing:

warning @stoplight/prism-cli > @stoplight/http-spec > @stoplight/json-schema-generator > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning @stoplight/prism-cli > @stoplight/http-spec > @stoplight/json-schema-generator > request > [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
warning @stoplight/prism-cli > @stoplight/http-spec > @stoplight/json-schema-generator > request > [email protected]: this library is no longer supported

I've created https://github.com/stoplightio/json-schema-generator/pull/7 to fix this, but can't find anyone willing to review it and merge. Looks like others noticed this in https://github.com/stoplightio/http-spec/issues/92 but it was closed without fixing the problem.

Context

Fix yarn and npm warnings about using a deprecated library.

Current Behavior

Installing @stoplight/http-spec or @stoplight/prism-cli causes yarn to emit warnings about using a deprecated library.

Expected Behavior

No warnings should be in the output.

Possible Solution(s)

Merge the change in https://github.com/stoplightio/json-schema-generator/pull/7 to use node-fetch instead.

strmer15 avatar May 17 '22 14:05 strmer15