stoplightio
chore(deps): bump node from 14.13 to 16.20
Fixes #2582 Related to STOP-619, STOP-638
This PR does the following:
- bumps node from 14.13 to 16.20
- bumps
@stoplight/scriptspackage from 9.3.4 to 10.0.0 - fixed all resulting type issues
- minor linting and code style updates
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
- [x] Read
CONTRIBUTING.md
Deploy Preview for stoplight-elements ready!
| Name | Link |
|---|---|
| Latest commit | d2c3d69a86da262a2d481dadfe57adafa3d60a44 |
| Latest deploy log | https://app.netlify.com/sites/stoplight-elements/deploys/66858689adc54900083c42f6 |
| Deploy Preview | https://deploy-preview-2606--stoplight-elements.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for stoplight-elements-demo ready!
| Name | Link |
|---|---|
| Latest commit | d2c3d69a86da262a2d481dadfe57adafa3d60a44 |
| Latest deploy log | https://app.netlify.com/sites/stoplight-elements-demo/deploys/66858689b2e465000850dfbc |
| Deploy Preview | https://deploy-preview-2606--stoplight-elements-demo.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Looks good! In my pr I also upgraded typescript to 5.4.5 in the root package.json. Not sure if that is needed here though.
In my pr I also upgraded typescript to 5.4.5 in the root package.json. Not sure if that is needed here though.
Good point, since the updated scripts package uses 5.4 as well. Regardless I'd like to introduce as little changes as possible. Upgrading the typescript will introduce quite a bit on top of already bloated PR. We can do this as a separate PR if needed.
Well, CI is passing https://app.circleci.com/pipelines/github/stoplightio/elements/9230 I'm not sure why it doesn't show it in the checks section
@daniel-white, thanks for the detailed review! I addressed all you comments and PR is ready for re-review 👍