elements
elements copied to clipboard
fix: remove the postfix License after the license name in AdditionalInfo
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
- [X ] Read
CONTRIBUTING.md
This pull request changes the way the license name gets rendered in HttpService
and should fix #2523
Deploy Preview for stoplight-elements ready!
Name | Link |
---|---|
Latest commit | a1edb554e2b194e818fac75d9ffb89dde236b56c |
Latest deploy log | https://app.netlify.com/sites/stoplight-elements/deploys/66bf36c71179930008431398 |
Deploy Preview | https://deploy-preview-2573--stoplight-elements.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for stoplight-elements-demo ready!
Name | Link |
---|---|
Latest commit | a1edb554e2b194e818fac75d9ffb89dde236b56c |
Latest deploy log | https://app.netlify.com/sites/stoplight-elements-demo/deploys/66bf36c7cef6100008683a2d |
Deploy Preview | https://deploy-preview-2573--stoplight-elements-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I don't know the team philosophy when the data doesn't match the OpenAPI spec. You could not display at all if the strict terms "mutually exclusive" aren't followed ( https://spec.openapis.org/oas/v3.1.0#license-object ) ; or you could error. Probably should follow whatever's your convention.
There's not a test case for "name" alone. Only name is required and if name alone is there, then it seems to me it it should be just the name text. You don't want to get "undefined" as the link.
@kentbulza Thanks, I have updated it
We do like this approach for fixing the postfix, but our team needs to do additional testing prior to merging this in.
Can we merge it? ❤️
@weyert Can we fix the tests please and then we should be good to merge!
@mnaumanali94 I have updated the tests
The end to end tests are funning for me locally. Not sure what's up with the CI
Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ api.cy.ts 00:04 10 10 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ stoplight-project.cy.ts 00:09 12 12 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! 00:14 22 22 - - -