elements icon indicating copy to clipboard operation
elements copied to clipboard

Uncommon HTTP verb badge is barely visible

Open P0lip opened this issue 3 years ago • 4 comments

Current Behavior

The badges for less common HTTP verbs such as HEAD or TRACE don't have any background, which makes it difficult to spot it given it's a white text on a gray-ish background. Here's how it looks like for some other HTTP verbs image image image image

image image

Expected Behavior

Add some generic background or change the color of text

P0lip avatar Sep 19 '22 13:09 P0lip

Issue seems to be on packages/elements-core/src/components/Docs/HttpOperation/HttpOperation.tsx

bg={!isDark ? HttpMethodColors[method] : 'canvas-100'}

The 'HttpMethodColors' do not have entries for Head or Trace falling back to the grey background.

Amjcraft avatar Sep 19 '22 16:09 Amjcraft

@keaslersarahaley @noor-ahmad What colors should we use here?

mnaumanali94 avatar Sep 23 '22 16:09 mnaumanali94

@mnaumanali94 can we try accent Purple - #9061F9 and #0D0B28 - dark blue

keaslersarahaley avatar Sep 23 '22 17:09 keaslersarahaley

I agree with @keaslersarahaley, we can give those a try

noor-ahmad avatar Sep 26 '22 14:09 noor-ahmad