pingvin-share
pingvin-share copied to clipboard
🚀 Feature: Decouple Nginx from official Docker
🔖 Feature description
I'm proposing the decoupling of Nginx from the official Docker image and instead relying on a separate image which can be used in conjunction with the main image with Docker Compose.
I can't really see the purpose of including Nginx in the official image for the application - other than making the install process quicker, which can be achieved with Docker Compose. I can however see a couple of limitations - such as the one mentioned in the README and that it adds unecessary complexity. It also kinda goes against the Docker philosophy of "one service per container".
🎤 Pitch
It will make it easier to work with.
I would like to add that this application looks extremely promising and seems to tick almost all the boxes of something that I've been looking for a while.
I don't know enough JavaScript/TypeScript to contribute in that area but if this is deemed a good idea I would be happy to put in the work to make it happen.
@matthew Yeah, I understand your point, and I create separate Docker images for my other projects as well. In the beginning of Pingvin Share, I also had two different images, but the self-hosted community suggested that I put everything in one container to simplify the setup.
For everyone, feel free to comment on this issue with your thoughts.
Nevertheless, it would be possible to create both an all-in-one Docker image and also two separate ones.
建议放一个docker-compose.yaml,会比一个docker image方便吧?
@jackadam1981 Please compose your comments in English as the most of use don't understand Chinese.