Toni Förster
Toni Förster
> The before_all handler isn't called for the error routes. See [kemalcr/kemal#663](https://github.com/kemalcr/kemal/issues/663). Is that likely to impact this PR? > > On those endpoints, Invidious will always be open to...
From my side, it is good to go.
> The user is being redirected but it seems like the handlers for the various endpoints are still being called in the end. Okay, but I assume that is something...
I'll take a look at this.
I'm currently short on time. I'll update the PR as soon as possible.
@syeopite is this PR intended to only work on iOS devices? When setting quality to HLS I'm only able to play back videos on an iPhone. Safari and all other...
One more thing I noticed. When using a third-party client like Yattee. Adding the instance and logging into an account is only possible when `login_only: false`. Are there some API...
There is another unhandled exeption: ``` 2023-11-09 18:02:26 UTC [info] 302 POST /feed/webhook/v1:1699275109:79a13f9f:051c7b138f7ac06da40a268a20537f3039d1810a 37.35ms Unhandled exception in spawn: Nil assertion failed (NilAssertionError) from /usr/share/crystal/src/nil.cr:113:7 in 'not_nil!' from /usr/share/crystal/src/nil.cr:109:3 in 'not_nil!'...
> The change appears functionally good to me, except it does introduce an unhanded error when loading the loading page whilst not logged in: > > ``` > 2023-11-09 14:59:59...
Well, these two endpoints could be added to the whitelist as well. Since video playback still wouldn't be possible without logging in.