stompjs
stompjs copied to clipboard
Replaced ping setInterval integration with webworker
The use of setInterval can be paused by the OS as soon as the browser tab or mobile browser app is in the background. Due to this behavior, the Stomp client library no longer sends ping messages and the Stomp server will close the connection. By using a webworker, the affected code will continue to run and ping-messages will be sent, even if the tab/app is not active.
This does look interesting and useful. A couple of feedback:
- Looking at the automated runs, this scheme does not work on NodeJS.
- We can add checks if WebWorkers are available and use the new behavior accordingly.
- In addition, we can introduce a flag to control this behavior.
Please only commit changes to the src folder. Makes it easier to review and compare.
Many thanks! The code looks beautiful. Please allow me a few days to review this.
I may have a few suggestions - those will be optional. In addition, if possible, we should figure out to include it as part of the tests as well.
Thanks for the review. Again, i fixed some minor issues. Tests should be running now.
Will release as pert of v7.1
Hi! sorry to ask, do you have an estimated ETA for v7.1? can't find that info, and this would be great to finally resolve the issue about timers throttled in chrome. Thanks!
Hi, does anyone know when v7.1 will be released. Sorry if this question makes anyone uncomfortable. Greetings.
Please refrain from asking for the release (and for anything else for that matter), as it will:
- Spam everybody's inbox that subscribed to this ticket
- Does not help in releasing this faster to the public
- Is straight up annoying