biblegatewayquick
biblegatewayquick copied to clipboard
Verse of the day should be changed based on date and not day number
Currently in src/verseOfTheDay.js
there is mechanism in place to check each time the verse of the day is request, if it has expired or not (i.e. if it's still the same day), this has been implemented by comparing day numbers (example Sunday = 1, Monday = 2), instead of whole dates (i.e. 23.05.2021).
This is a bug because if a user only uses the browser on, say, Sundays, the mechanism will conclude it's the same date, which is wrong, and not fetch a new verse of the day.
I made a bug fix contribution for this issue. Actually this is my very first contribution. I want to know whether my fix is worked perfectly or not ?