John Storey
John Storey
@jinlii That is the expected behavior. By creating `mockList` in the test, a virtual copy of `fflib_MyList` is created that is used instead. Generally mocking classes, as done in this...
@AllanOricil Skip specifying the `mocks.when(...)` statement. Simply do the verify. As in ... ``` fflib_ApexMocks mocks = new fflib_ApexMocks(); IMyService mockMyService = (IMyService) mocks.mock(IMyService.class); // Execute the test implementing the...
@wimvelzeboer I'm going to take a look at this, but for starters, could you please address the conflicts as you see fit respecting other changes to 'master'.
@ImJohnMDaniel Since you and I regularly debate matters of pattern implementations, do you have observations about the general pattern existing here?
@jinlii Could you provide some more background and information about this Issue? Please include sanitized versions of the relevant code and other relevant information. Especially helpful would be a minimized...
Seeing a lot of PR approvals and merges today, when this phase is concluded & stabilized, we can conduct an all-inclusive insignificant code refactoring, and commit with proper tagging.
Hi @jinlii (1) Although it's evident that you're mocking the service implementation in the test, the test-sphere naming is a bit confusing. (2) The mock should implement the ITeachersService interface...
All of that is right on, and as long as the "Kitchen Sink" implements `fflib_ISObjectSelector`, you'll be fine. Additionally the selector implementation could contain a static `newInstance()` method that calls...
@wimvelzeboer We discussed the PR during our monthly meeting, and although we like the direction, we're going to hold this PR because we're planning a conversation with @capeterson this month...
Hi @EmilioMN92 I think I see what might be happening here, but I cannot reproduce with a more simple test, included below. I'd have to do a bit more research....