StofDoctrineExtensionsBundle icon indicating copy to clipboard operation
StofDoctrineExtensionsBundle copied to clipboard

Added an option to disable Locale listener

Open romaricdrigon opened this issue 10 years ago • 7 comments

Hi,

In some case, using the Symfony2 locale (for example from the Request) to automatically filter entities using the Translatable extension can lead to unwanted results. I came across such case in an application where the locale was already managed explicitly.

In this PR, we create an optional disable_locale_listener option. The default value is true, so there are no BC break.

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? ~
Fixed tickets ~
License MIT
Doc PR Doc written

romaricdrigon avatar Apr 09 '14 12:04 romaricdrigon

@romaricdrigon are you still interested in this feature ? If yes, please update it based on the feedback I gave you previously, and please rebase it to fix conflicts

stof avatar Aug 11 '15 15:08 stof

I can continue the work if needed. I definitively need this feature

tyx avatar Aug 13 '15 12:08 tyx

I was not sure anyone but me was needing that one. Sure I will work on it.

romaricdrigon avatar Aug 13 '15 12:08 romaricdrigon

Definitely a must have :+1:

shouze avatar Aug 13 '15 13:08 shouze

Hi all, I've just updated my code with your feedback @stof , and squashed my commits.

romaricdrigon avatar Aug 18 '15 09:08 romaricdrigon

Oh yeah! can't wait!

shouze avatar Aug 18 '15 10:08 shouze

Ping @stof : this can be merged IMO ?

Pierstoval avatar Dec 30 '15 09:12 Pierstoval