self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

fix: Mounting Revolt.toml in compose.yml

Open ReStranger opened this issue 1 year ago • 16 comments

Please make sure to check the following tasks before opening and submitting a PR

Co-authored-by: @loss-and-quick

  • [x] I understand and have followed the contribution guide
  • [x] I have tested my changes locally and they are working as intended

ReStranger avatar Oct 08 '24 18:10 ReStranger

Is there an issue with the one-line bind mount?

insertish avatar Oct 28 '24 13:10 insertish

Is there an issue with the one-line bind mount?

Yes, file mounts as folder path, not as file

loss-and-quick avatar Oct 29 '24 14:10 loss-and-quick

@loss-and-quick I'm pretty sure it's not, the default config is working for me:

  • /apps/revolt/Revolt.toml:/Revolt.toml

Mateleo avatar Dec 10 '24 20:12 Mateleo

@loss-and-quick I'm pretty sure it's not, the default config is working for me:

  • /apps/revolt/Revolt.toml:/Revolt.toml

🤔🤔

loss-and-quick avatar Dec 14 '24 00:12 loss-and-quick

Okay it does seem to do a check if the source exists, which is better than not having it I suppose. Cherry picking the change since there are other services to be included now.

insertish avatar Dec 17 '24 17:12 insertish

Good cherry pick chore: switch to bind mount format. Why don't you cite authorship?

ReStranger avatar Dec 17 '24 19:12 ReStranger