stm32h7xx-hal
stm32h7xx-hal copied to clipboard
stm32-rs
update GPIO 2
I am 👍 on this because I end up switching pins between pull-up and pull-down in certain situations and having the typestate makes this very annoying.
It looks like you removed pull-up and floating from some examples but never set the input type elsewhere. I feel like the examples should set the input type to maintain previous functionality, especially for simple dev board setups that often rely on the internal pull ups to set signal level of buttons etc...
On Tue, Apr 5, 2022, 11:11 AM Matt Ickstadt @.***> wrote:
I am 👍 on this because I end up switching pins from pull-up to pull-down in certain situations and having the typestate makes this very annoying.
— Reply to this email directly, view it on GitHub https://github.com/stm32-rs/stm32h7xx-hal/pull/346#issuecomment-1088946854, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUS5FIGVKY7L7FHZRD5SFLVDRQ33ANCNFSM5SSO252Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>
It looks like you removed pull-up and floating from some examples but never set the input type elsewhere.
into_pull_up_input nowhere gone. It is just not present in type definition now.
Oops, sorry about that. I was just looking at the diff which said nothing about pull-up/pull-down, the initialization didn't change so I didn't examine closely enough.
Looks great to me!
On Tue, Apr 5, 2022, 11:26 AM Zgarbul Andrey @.***> wrote:
It looks like you removed pull-up and floating from some examples but never set the input type elsewhere.
into_pull_up_input never gone. It is just not present in type definition now.
— Reply to this email directly, view it on GitHub https://github.com/stm32-rs/stm32h7xx-hal/pull/346#issuecomment-1088980419, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUS5FNPM3PNG2TE24NIF5DVDRSULANCNFSM5SSO252Q . You are receiving this because you commented.Message ID: @.***>