stm32g0xx-hal icon indicating copy to clipboard operation
stm32g0xx-hal copied to clipboard

Spelling error `dma_circualr_mode()`

Open dauntown opened this issue 1 year ago • 2 comments

pub trait DmaMode<ADC> {
    /// Error type returned by ADC methods
    type Error;
    fn dma_enable(&mut self, enable: bool);
    fn dma_circualr_mode(&mut self, enable: bool);   // <=======
}

Here DmaMode contains the method dma_circualr_mode(). Please correct it to dma_circular_mode(). The name error doesn't inspire confidence it will in fact work.

As seen on https://github.com/stm32-rs/stm32g0xx-hal/blob/e6145ef83c639e736556fb4775f349aef7100ad6/src/analog/adc.rs#L374C16-L374C16

dauntown avatar Jan 15 '24 14:01 dauntown

Thanks! Would you like to create a PR to fix the typo?

Disasm avatar Jan 15 '24 15:01 Disasm

No thanks, the honor, and the breaking change, is all yours.

dauntown avatar Jan 15 '24 15:01 dauntown