stm32f7xx-hal icon indicating copy to clipboard operation
stm32f7xx-hal copied to clipboard

Possible typo in maximal frequency.

Open matoushybl opened this issue 3 years ago • 2 comments

There are two different frequencies mentioned in the comments and in the code.

https://github.com/stm32-rs/stm32f7xx-hal/blob/0a0d06d5f63c3a1471362370fdfb8c367207d308/src/rcc.rs#L468-L476

matoushybl avatar Oct 19 '21 12:10 matoushybl

Thank you, good catch! Just from reading the code, it's not clear to me whether this is actually wrong, but it definitely looks dubious.

Even it this doesn't need fixing, a better comment would be great.

hannobraun avatar Oct 20 '21 11:10 hannobraun

Oh, I see it now. Sorry for the mistake, I agree with adding a slightly improved comment, but I believe we could also extract the frequencies for example to a module with constants.

matoushybl avatar Oct 20 '21 14:10 matoushybl