bxcan icon indicating copy to clipboard operation
bxcan copied to clipboard

Published 20 hours ago • verified publisher icon stm32-rs

Update embedded hal traits

Open T-Bakker opened this issue 1 year ago • 2 comments

This PR updates the embedded-hal dependency and switches to its replacement embedded-can. This means that now socketcan and bxcan share a common trait in the embedded-can library, which me really would like.

T-Bakker avatar Dec 13 '23 11:12 T-Bakker

Wondering what's blocking this?

tristanguerragomez avatar Feb 23 '24 14:02 tristanguerragomez

Would be nice to have this

dimpolo avatar Apr 15 '24 18:04 dimpolo

@adamgreig could you please take a look at this?

dimpolo avatar Sep 13 '24 17:09 dimpolo

Thanks for the quick response @adamgreig but that's not quite what I meant 😅

@jonas-schievink seems to no longer be maintaining this crate and I was hoping you could either get this merged and released or facilitate someone else doing so.

dimpolo avatar Sep 13 '24 23:09 dimpolo

Yep, can do. I had hoped to have a clean merge button after reviewing but I'm not technically on the team for it 😅

Is anyone interested in helping to maintain this crate? I can get this merged and do a release (though probably not for a day or two, I'm travelling atm) but more usefully if anyone is interested I can get you set up.

adamgreig avatar Sep 14 '24 00:09 adamgreig

Awesome, thank you!

I wouldn't mind helping out :)

dimpolo avatar Sep 16 '24 08:09 dimpolo

This is now released at 0.8. Thanks for offering to help! I don't have time to set it up right now but will try and get it sorted in the next few days. Ping me if you get bored of waiting!

adamgreig avatar Sep 17 '24 01:09 adamgreig