Flask-MQTT icon indicating copy to clipboard operation
Flask-MQTT copied to clipboard

Published 20 hours ago • verified publisher icon stlehmann

Releasing a new version

Open skrapi opened this issue 4 years ago • 8 comments

Is it possible to release a new version with some of the recent changes? If there is anyway I could do it, I would happily put the effort in.

skrapi avatar Sep 29 '20 11:09 skrapi

@stlehmann @skrapi I would like to see that 1.1.2 released as well so I can dispense with my custom changes. Can we get it released?

kim-acmehi avatar Oct 08 '20 21:10 kim-acmehi

@skrapi @kim-acmehi There is still one issue where Python 3.6 does not pass the tests. But I think I can make a new release this weekend.

stlehmann avatar Oct 09 '20 06:10 stlehmann

@stlehmann Great, please do let me know if I can help in any way.

skrapi avatar Oct 09 '20 07:10 skrapi

@kim-acmehi, @skrapi sorry to keep you waiting but I'm quite busy at the moment and couldn't manage to draft a new release, yet. If you are not using Python 3.6 then you can already use the newest version by installing the master-branch version directly with pip.

stlehmann avatar Oct 15 '20 13:10 stlehmann

@stlehmann I am using Python 3.7 so this is not an issue for me. I know how it goes being busy. I will have a look at the failure in travis-ci and see if I can get a clue why it is failing on Python 3.6. But I might be too busy to get to it this weekend. :)

kim-acmehi avatar Oct 16 '20 19:10 kim-acmehi

@stlehmann I finally had some time to look at the failing Python 3.6 test. Running deploy.sh by hand with Python 3.6 I found that test_on_topic does pass sometimes but mostly fails. I set up an overnight run of the deploy.sh iterations. Out of about 1150 test runs test_on_topic:

FAILED: 805 PASSED: 350

I did try upping the wait() time from 5 seconds but it did not seem to make any difference. Since it fails more often than not I think the next step to to watch the log messages on the mosquitto server and see how a passing and failing test compares. If you have any other idea please let me know.

kim-acmehi avatar Oct 22 '20 17:10 kim-acmehi

@kim-acmehi thanks for digging into this. I created a new issue for further discussions.

stlehmann avatar Oct 23 '20 06:10 stlehmann

@stlehmann I see the tests are now working and there's been lots of improvements on the paho-mqtt side Is a new release still underway?

I also noticed a few discrepancies:

flask-mqtt

Location Version
example/ 1.0.5

paho-mqtt

Location Version
example/ 1.5.0
requirements/ 1.4.0
requirements.txt 1.6.1

Should I make a PR to update flask-mqtt to 1.1.2 and paho-mqtt to 1.6.1?

MrTanoshii avatar Apr 04 '22 12:04 MrTanoshii