JSON-java icon indicating copy to clipboard operation
JSON-java copied to clipboard

Enhancement: Replace assetTrue with assetEquals in tests

Open Simulant87 opened this issue 1 year ago • 2 comments

There are a lot of tests with an Aaron pattern like

assertTrue("message", expected.equals(actual))

If such an fails, it only returns the message as indicator of the failure, but the difference in expected to actual value is not visible.

The assertions should be changed to:

assertEquals("message", actual, expected)

This way a failing assertion would also output the difference, which would make it easier to find the reason for it.

I would like to work on this issue and provide a PR to improve the assertions.

Simulant87 avatar Feb 22 '24 09:02 Simulant87