jsTreeR icon indicating copy to clipboard operation
jsTreeR copied to clipboard

Update jstreer.js

Open ismirsehregal opened this issue 1 year ago • 8 comments

Again using changed.jstree event instead of select_node.jstree and deselect_node.jstree to fix https://github.com/stla/jsTreeR/issues/34

The fix for https://github.com/stla/jsTreeR/issues/16 is not affected

ismirsehregal avatar Jul 15 '24 07:07 ismirsehregal

Hi @ismirsehregal

Did you identify the reason for which I commented out the line? Because I don't want to restore this line if I don't know this reason.

stla avatar Jul 17 '24 09:07 stla

Hi Stéphane, it seems you haven't actually commented it out. The (commented) line was added with this commit (triggered by this issue) (see the diff - nothing was deleted. Maybe it was just for testing and you haven't noticed any difference?).

However, if you rather want to keep using the select_node.jstree and deselect_node.jstree events instead of changed.jstree, we could add listeners for select_all.jstree / deselect_all.jstree as an alternative solution. Although, I haven't noticed any issue using changed.jstree and it seems to be the recommended way as it covers all cases.

ismirsehregal avatar Jul 17 '24 10:07 ismirsehregal

Hi Stéphane, have you had the chance to test this? Cheers

ismirsehregal avatar Jul 29 '24 09:07 ismirsehregal

My main laptop is dead. Now I only have an old one (with Windows 7) and I don't like to work on this one. But I will.

stla avatar Jul 29 '24 14:07 stla

Okay - thanks for the update! Please let me know if there is anything I can do to help. Cheers

ismirsehregal avatar Aug 01 '24 11:08 ismirsehregal

Yes you can ;-) Tell me whether there's a nice IDE for R that works with Windows 7. I really miss RStudio.

stla avatar Aug 02 '24 00:08 stla

Uh 🙈... that's bad.

Maybe you can downgrade: https://forum.posit.co/t/what-is-the-latest-rstudio-version-for-windows-7/152152

..or once I installed RStudio Server on a Raspberry Pi 😅

ismirsehregal avatar Aug 02 '24 07:08 ismirsehregal

Hi Stéphane, I just wanted to leave a frindly reminder, that it would be really helpful if this is merged (or the alternative approach mentioned above is implemented).

Cheers

ismirsehregal avatar Sep 11 '24 11:09 ismirsehregal