devika icon indicating copy to clipboard operation
devika copied to clipboard

Refactored config.py: Replaced 'config.toml' by _CONFIG_FILE

Open fauneau opened this issue 1 year ago • 1 comments

In the class Config in config.py, I replaced the multiple occurences of 'config.toml' by the class constant _CONFIG_FILE. This aims to make the code:

  • easier to maintain
  • clearer

by:

  • expliciting what "config.toml" represents
  • reducing the amount of literal values in the code.

PS: This is my first contribution to an open source project. I would highly value any comment that would help me make better contributions in the future

fauneau avatar Mar 28 '24 14:03 fauneau

Sorry, I did not mean to get the commit 930db0b added to the pull request. I'm guessing I shouldn't use rebase to get my fork up-to-date

fauneau avatar Mar 28 '24 23:03 fauneau

Well, that wasn't pretty, sorry about that. But, now, the pull request is fixed.

fauneau avatar Mar 29 '24 13:03 fauneau

The commit from this pull request is available through pull request #248. As such, I'm closing this request.

fauneau avatar Mar 29 '24 14:03 fauneau