devika icon indicating copy to clipboard operation
devika copied to clipboard

Add precommit configurations & basic GitHub actions

Open franklinselva opened this issue 1 year ago • 4 comments

Resolves #153

franklinselva avatar Mar 27 '24 05:03 franklinselva

The PR cannot be merged at this point yet since it has a lot of expected formatting and linting changes. The details are available at this job.

I will update the install scripts for normal setup and dev setup soon.

franklinselva avatar Mar 27 '24 06:03 franklinselva

Hey @franklinselva, please let me know when you want this to be merged, the PR looks okay to me so far! Thanks! 🙌

mufeedvh avatar Mar 28 '24 09:03 mufeedvh

@mufeedvh I think waiting until #24 is merged is better since this PR will likely add more conflicts. Once merged, i will push the rest of formatting and linting related changes for merging.

franklinselva avatar Mar 28 '24 19:03 franklinselva

@mufeedvh I think we can go ahead with merging this PR. Can you go through the changes? This commit is strictly formatting related changes. The linting part is being improved as a part of refactoring

franklinselva avatar Mar 29 '24 12:03 franklinselva