hamilton icon indicating copy to clipboard operation
hamilton copied to clipboard

Prototype for typed_tag. Solve

Open elijahbenizzy opened this issue 2 years ago • 0 comments

https://github.com/stitchfix/hamilton/discussions/276

This is a little rough -- we need more testing. But it should work. Followed the spec at it was fairly clean -- using typed dicts, and validating on decoration. Also restricting to only primitives -- we can change it later but I want to keep things a lot simpler for now.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • [ ] PR has an informative and human-readable title (this will be pulled into the release notes)
  • [ ] Changes are limited to a single goal (no scope creep)
  • [ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • [ ] Any change in functionality is tested
  • [ ] New functions are documented (with a description, list of inputs, and expected output)
  • [ ] Placeholder code is flagged / future TODOs are captured in comments
  • [ ] Project documentation has been updated if adding/changing functionality.

elijahbenizzy avatar Jan 15 '23 07:01 elijahbenizzy