react-spring-bottom-sheet icon indicating copy to clipboard operation
react-spring-bottom-sheet copied to clipboard

Fix Incorrect aria-modal Usage

Open laurencepresland opened this issue 2 years ago • 1 comments

This PR sets the value of the aria-modal attribute based on the value of the blocking prop. According to the MDN Web Docs the aria-modal attribute is designed to limit screen readers to a particular area of an application. Therefore I think it makes sense that it should be set in line with the blocking prop.

Without this fix there is no way to set aria-modal to false therefore screen readers which respect the attribute (currently only iOS as far as I know) will always be stuck in the bottom sheet.

laurencepresland avatar Aug 09 '22 09:08 laurencepresland

+1 on this. This is currently breaking accessibility on iOS devices if the bottom sheet is set to blocking={false}

alex-reid avatar Aug 10 '22 00:08 alex-reid