ioredis-mock icon indicating copy to clipboard operation
ioredis-mock copied to clipboard

Update ioredis-mock to support Cluster

Open sothychan opened this issue 8 years ago • 9 comments

Currently, ioredis-mock does not have a way to mock a Redis.Cluster set up. What's the level of effort it will take to make that happen?

sothychan avatar Feb 21 '18 22:02 sothychan

Actually not that much effort.

In a testing context RedisMock.Cluster would simply be a normal RedisMock instance but with a few extra cluster-specific commands and a few differences in how transactions and pipelines work.

Would that fit your mocking needs?

stipsan avatar Feb 22 '18 00:02 stipsan

@stipsan Yes, it would. Thank you for your quick response!

sothychan avatar Feb 22 '18 08:02 sothychan

Ok great! 😄 I’ll see if I can get it done over the weekend 🤔

  1. feb. 2018 kl. 09:36 skrev Sothy Chan [email protected]:

@stipsan Yes, it would. Thank you for your quick response!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

stipsan avatar Feb 22 '18 11:02 stipsan

Hey again, I didn't have time this weekend but I'll try and get it done this week 😃

stipsan avatar Feb 25 '18 23:02 stipsan

Hi @stipsan, any progress on this? :)

Thanks for the module!

Kumjami avatar Mar 27 '18 08:03 Kumjami

Hey @Kumjami, I'll get to this today 😄

stipsan avatar Mar 30 '18 15:03 stipsan

This would be great!

nabeelio avatar Apr 01 '19 18:04 nabeelio

I likely won't have time to work on this anytime soon, but if anyone sends in a PR I'll review it, merge and release! 😄

stipsan avatar Apr 02 '19 10:04 stipsan