Cody Olsen

Results 133 comments of Cody Olsen

I saw one project that started doing it this way: https://github.com/testing-library/react-testing-library/blob/89d11b08c61f3cf5af770c61a03d564b3fdc301c/package.json#L50

Hi @squareloop1, not really. We'll most likely rewrite this repo to be written in TS and generate the type defs during build. I don't have any timeframe for that though.

> Issue still occuring :( PRs welcome 😉

Last I checked there wasn't any, but I noticed that there's a `@types/ioredis` already. Even though my long term goal for this library is to move all of it to...

Hey, could you make a [repro on RunKit](https://runkit.com/npm/ioredis-mock)?

Thanks @moyarich! I see now that the error comes from bull queue trying to call [CLIENT SETNAME](https://redis.io/commands/client-setname), while we don't support the [CLIENT suite of redis commands yet](https://github.com/stipsan/ioredis-mock/blob/master/compat.md#supported-commands-). PRs welcome...

Hey @Abhi-Codes the reason it's not working is because `ioredis-mock` doesn't support Sentinels yet. This PR needs to land before we can start working on that: #997

Hey you're welcome to send in [a PR that adds them](https://github.com/stipsan/ioredis-mock/blob/2da1aa662d912d41ea9eee7ccc329913295b42d4/src/lua.js#L165-L179). I would love to do it myself but I have zero Lua experience and wouldn't even know where to...