Cody Olsen comments

Results 133 comments of


                                            Cody Olsen

nullable members weird rendering behaviour

Here's the source of this behavior https://github.com/danielgtaylor/aglio/blob/olio-theme/src/example.coffee#L17

nullable members weird rendering behaviour

Looks like you can disable it by setting `DRAFTER_EXAMPLES=true`. Like so: `DRAFTER_EXAMPLES=true aglio -i apiary.apib`.

fix scroll distance when frame in a scaled box

Hey @shiftonetothree, thanks for the PR! 😄 Can you add tests, so we can avoid regressions when refactoring later?

Not working in safari/edge if you want to scroll document.body

Yeah that's because in those browsers the body is the scrolling element. You can verify this by checking `document.scrollingElement`. The reason why it works firefox and chrome is that `document.documentElement`/``...

Not working in safari/edge if you want to scroll document.body

Yeah it caught me off guard as well. I discovered it while working on Browserstack tests. I got some time to look into this some more earlier this evening. I...

Check of if element is in viewport can fail under certain conditions

Hey @Francesco-Lanciana! You're welcome to do a PR 😄 Good investigative work 🕵️

nodes is not a function error (redis cluster)

Hi, Clusters are indeed not fully supported. PRs welcome ☺️

`cmsgpack` global object is missing in lua context

I tried to setup an experiment with it but it's painfully obvious that Lua isn't my forte 😭

Unexpected true value, for non-existing key

Hi, you're most likely affected by the change explained [here](https://github.com/stipsan/ioredis-mock#from-v5-to-v6). Unless it's a bug/regression in `redis.expire`?

ioredis-mock `rpop` doesn't react the same as ioredis `rpop`

Hey thanks for the report 😄 I don't have time to work on this anytime soon but PRs are welcome and I'll be sure to review and release ❤