Stijn Tintel
Stijn Tintel
That happens already and it tells us the style of your contribution does not comply. Modifying code in CI and having CI commit changes is not something I feel comfortable...
According to my testing 5 minutes ago Ubuntu 22.04 has clang-15.
That being said, this is what running `clang -i` locally makes of it. I don't particularly like it, but enforcing a style is non-negotiable. Feel free to introduce a change...
``` ➜ podman run --rm -it ubuntu:22.04 root@315adb7bc6d3:/# apt update Get:1 http://archive.ubuntu.com/ubuntu jammy InRelease [270 kB] Get:2 http://security.ubuntu.com/ubuntu jammy-security InRelease [110 kB] Get:3 http://archive.ubuntu.com/ubuntu jammy-updates InRelease [119 kB] Get:4 http://security.ubuntu.com/ubuntu...
I considered ```diff -ColumnLimit: 120 +ColumnLimit: 140 ``` But that would trigger other failures... There should really be an option to allow putting first variable argument on a new line...
Alright. Easy solution: instead of using "MAC address" as first argument to ESP_LOGI, just use TAG. Printing `"MAC address: MAC address ..."` would be confusing anyway.
Indeed, I use rootless podman with the following command line: ``` podman run --rm -it --hostname=willow-builder --userns=keep-id --group-add keep-groups --volume "${PWD}:/willow" --device /dev/ttyACM0 --env PORT=/dev/ttyACM0 willow ``` The `--userns=keep-id` option...
Should be improved by fed9875488e7a39481a043a3c1642fb1f9aeb7d6. Still not perfect though.
Maybe we can close this after ce2749abe49fa64bd255a916d89fd95876c46fe8 and 4fe4b238e326fc358dea048d155738fd7acc4328?
I do sometimes press the cancel button because VAD/WAKE end don't trigger. This happens very often right after booting the device. This might be related to https://github.com/espressif/esp-sr/issues/47#issuecomment-1259365973: > Why we...