elm-analyse icon indicating copy to clipboard operation
elm-analyse copied to clipboard

Doesn't pickup files from the tests folder

Open razzeee opened this issue 5 years ago • 4 comments

Probably due to them missing here? https://github.com/stil4m/elm-analyse/blob/master/ts/util/file-gatherer.ts#L27

razzeee avatar Jun 09 '19 00:06 razzeee

Yes. This was originally designed how elm test functioned in 0.18. It would make more sense to include test files as well at this moment

stil4m avatar Jul 08 '19 05:07 stil4m

so how should we proceed with this?

razzeee avatar Jul 12 '19 18:07 razzeee

A change has to be made to make this work. I propose to extend the mechanism of collecting source files to also collect the test files. This would only apply if there are dependencies in the test-dependencies block (I think that is a sufficient predicate).

I'm not sure how including test files will affect the program. For example, a dependency is actually unused if it is only used in test code and not source code. Thus to actually pertain the same properties as the system does now, files should be marked as test files.

If I got time I can do a POC, or feel free to prepare a POC yourself.

stil4m avatar Jul 12 '19 18:07 stil4m

I probably won't have time, have some things I need to do for the elm language server. Which includes upstreaming our elm-analyse fork :)

razzeee avatar Jul 12 '19 18:07 razzeee