gif-endec Severe gif encoding bug

Severe gif encoding bug

Open mjphaynes opened this issue 5 years ago • 2 comments

There is a bug here: https://github.com/stil/gif-endec/blob/9b9b7d4957a2283bdbd25d8a667a41c419c125f5/src/Encoder.php#L183

See here for correct logic: https://github.com/lunakid/AnimGif/blob/master/src/GifCreator/AnimGif.php#L361

This causes gifs to be corrupted in certain situations

Jan 23 '20 11:01 mjphaynes

I have an issue with corrupted gifs as well, but the linked code looks comparable. I think the issue is elsewhere, but I've not found it yet

Jan 27 '20 21:01 marrone

Yeah this could be your issue as well as this is a pretty major flaw in the logic.

I don't know if this package is still maintained? If it is I could submit a pull request?

Jan 28 '20 09:01 mjphaynes