Stijn Van Hoey
Stijn Van Hoey
@adokter can you be more precise about which plotting methods or when this happens? For the `plot.scan` method: ``` library(bioRad) library(ggplot2) data(example_scan) myplot
ok, this works for me (please, no comments on color choice ;-)): ``` # plot scan data(example_scan) myplot
maybe related to [this](https://github.com/tidyverse/ggplot2/issues/1101)
I agree on the `Rcurl`/`curl` redundancy. We probably can exclude lubridate with a small effort, but apart from those I can't see direct possibilities to exclude the other dependencies. I...
Checking this a bit further on the develop branch [dpendencies](https://github.com/adokter/bioRad/blob/86f3d490f54a0624ff54f4dff8ec3253eff7197f/DESCRIPTION#L18-L31): ``` curl, fields, ggmap, ggplot2, graphics, lubridate, methods, raster, RCurl, rgdal, rhdf5, sp, stats, utils, maptools ``` and the [NAMESPACE](https://github.com/adokter/bioRad/blob/develop/NAMESPACE):...
Check! I'm not taking it into account in the current renaming work, but let's put this on the enhancement list!
To have a safe roadmap and at the same time gain test-coverage: ;-) 1. create tests for the current input checks, make them work 2. rewrite with `assertthat`
I agree, should indeed not break anything (just taing care of backward compatibility).
The dependency of `Rcurl` can be removed when we replace the `getBinaryURL` function which is used to check the existence of an URL in the helper function `check_url_existence`. We could...
To be clear: there is no need to replace the current `curl_download` function (from `curl` package) with a function from `httr`, as this would not remove a dependency (`httr` relies...