Julio C. Galindo
Julio C. Galindo
@YuriiMotov can you label this as a bug?
> Any idea on when a new release with this fix will be available? Not really, hopefully soon! I would still recommend to use `pydantic
> Hi @stickM4N, thanks for the PR! I'm going to push some changes to your branch directly, to include also the tests from #1602 and to get the PR in...
> FYI PR #1607 works with `__future__.annotations` as well, whereas this one does not. Can you provide more details on this?
@YuriiMotov could you review this and label it?
> Could you please comment on the implementation of the algorithm? > > Also, looks like the title and description of PR don't match the changes. > > We should...
@svlandeg could you please take a look at this?
@YuriiMotov Thanks for the quick feedback. When I was doing research about this, I saw that PR (and also an [old branch](https://github.com/fastapi/fastapi/tree/feat/custom-generate-json-schema) still in the repo, probably deprecated...) Their approach...
Thanks for the review, but I'll add tests soon and I would like to discuss with you another point that is worth taking into account. So please don't merge it...