Stian Thorgersen

Results 175 comments of Stian Thorgersen

> The manual run is not enough to resolve this issue? We need two things here to resolve this issue: * Test PRs to 19.0 branch against 19.0 branch in...

Could you provide a reproduce? It's most likely caused by some trivial mistake on how you created it

I've just tried this out here and the issue is in the new admin console. The old admin console shows the list of locales based on the current selected login,...

Added a basic example here https://github.com/stianst/playground/tree/main/sunrise that can be used to test the new admin console.

From the old admin console when sunrise example from above is applied it will only show `az` as the option: ![image](https://user-images.githubusercontent.com/2271511/196388055-d094967d-82fb-4d7f-9480-fd9b052c229e.png) However, the new admin console shows all built-in locales...

Just tried the latest nightly and can't see any changes in behaviour there, so believe the issue still exists.

The way the old admin console does it is by only showing locales that are supported by all end-user facing themes (account, login, and email).

Yeah, so to add a custom locale you need to have a custom theme for account, login, and email. That's exactly what https://github.com/stianst/playground/tree/main/sunrise is doing. The "custom theme" doesn't strictly...

Not the most elegant, but this is what the old admin console does: https://github.com/keycloak/keycloak/blob/43a3677cc727469a7c0d46c95436420e0ff3feb5/themes/src/main/resources/theme/base/admin/resources/js/controllers/realm.js#L543-L579

Could you provide some description of what this PR is about?